kou commented on code in PR #34835:
URL: https://github.com/apache/arrow/pull/34835#discussion_r1155126134
##########
dev/tasks/python-wheels/github.linux.yml:
##########
@@ -49,6 +71,7 @@ jobs:
archery docker run python-wheel-manylinux-test-imports
archery docker run python-wheel-manylinux-test-unittests
+ {% if arch == "amd64" %}
Review Comment:
Can we enable this on arm64 too?
##########
dev/tasks/tasks.yml:
##########
@@ -456,12 +456,13 @@ tasks:
{############################## Wheel Linux ##################################}
-{% for ci, arch, arch_alias, x_y, manylinux in [("github", "amd64", "x86_64",
"2_17", "2014"),
- ("travis", "arm64", "aarch64",
"2_17", "2014")] %}
+{% for arch, arch_alias, x_y, manylinux in [("amd64", "x86_64", "2_17",
"2014"),
+ ("arm64", "aarch64", "2_17",
"2014")] %}
Review Comment:
```suggestion
("arm64", "aarch64", "2_17",
"2014")] %}
```
##########
dev/tasks/python-wheels/github.linux.yml:
##########
@@ -22,15 +22,37 @@
jobs:
build:
name: "Build wheel for manylinux {{ manylinux_version }}"
+ {% if arch == "amd64" %}
runs-on: ubuntu-latest
+ {% else %}
+ runs-on: ["self-hosted", "Linux", "arm64"]
+ {% endif %}
env:
# archery uses these environment variables
+ {% if arch == "amd64" %}
ARCH: amd64
+ {% else %}
+ ARCH: arm64v8
+ {% endif %}
PYTHON: "{{ python_version }}"
steps:
{{ macros.github_checkout_arrow()|indent }}
+ {% if arch == "amd64" %}
{{ macros.github_install_archery()|indent }}
+ {% else %}
+ - name: add path
+ run: echo "$HOME/.local/bin" >>"$GITHUB_PATH"
+ - name: Install python # Workaround for arm64
https://github.com/actions/setup-python/issues/108
+ shell: bash
+ run: |
+ sudo apt-get update
+ sudo apt-get install -y python3-pip
+ pip3 install -U pip
+ - name: Install Archery
+ shell: bash
+ run: pip3 install -e arrow/dev/archery[all]
Review Comment:
Could you do this in `macros.jinja` like
https://github.com/apache/arrow/pull/34717/files#diff-77e693ebc06aba9fdd8c4b8d27e8ddcf54d91db8dbb7c060910e4a9c25d76a3c
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
