srebhan commented on code in PR #35051:
URL: https://github.com/apache/arrow/pull/35051#discussion_r1164344490
##########
go/arrow/flight/flightsql/driver/config.go:
##########
@@ -19,9 +19,53 @@ import (
"crypto/tls"
"fmt"
"net/url"
+ "sync"
"time"
+
+ "github.com/google/uuid"
+)
+
+// TLS configuration registry
+var (
+ tlsConfigRegistry = map[string]*tls.Config{
+ "skip-verify": {InsecureSkipVerify: true},
+ }
+ tlsRegistryMutex sync.Mutex
Review Comment:
I can certainly do this, but I don't expect this to be in a hot-path.
Remember, the mutex is locked if you register a config _and_ when you are
calling `Open` (which in turn does the DSN parsing). Do you want me to use a
`RWMute`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
