srebhan commented on code in PR #35051:
URL: https://github.com/apache/arrow/pull/35051#discussion_r1164355487
##########
go/arrow/flight/flightsql/driver/config.go:
##########
@@ -30,14 +74,15 @@ type DriverConfig struct {
Timeout time.Duration
Params map[string]string
- TLSEnabled bool
- TLSConfig *tls.Config
+ TLSEnabled bool
+ TLSConfigName string
+ TLSConfig *tls.Config
}
func NewDriverConfigFromDSN(dsn string) (*DriverConfig, error) {
u, err := url.Parse(dsn)
if err != nil {
- return nil, err
+ return nil, fmt.Errorf("invalid URL: %w", err)
}
// Sanity checks on the given connection string
Review Comment:
I guess that's because I wanted to keep the same scheme other SQL drivers
use (see https://github.com/xo/dburl#example-urls). I think we could also
support the ones above even though I don't like the redundant `grpc`...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
