lidavidm commented on code in PR #35098:
URL: https://github.com/apache/arrow/pull/35098#discussion_r1168125919
##########
cpp/src/arrow/array/data.cc:
##########
@@ -144,6 +144,8 @@ std::shared_ptr<ArrayData> ArrayData::Slice(int64_t off,
int64_t len) const {
} else {
copy->null_count = null_count != 0 ? kUnknownNullCount : 0;
}
+ for (auto& child : copy->child_data)
+ child = child->Slice(copy->offset, copy->length);
Review Comment:
In this case, you should explicitly pass around the parent offset or adjust
the child offsets.
It may be reasonable to provide a method on Array that can pre-adjust the
children for you (without actually copying the data).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
