tustvold commented on code in PR #4133:
URL: https://github.com/apache/arrow-rs/pull/4133#discussion_r1177052549
##########
arrow-csv/src/reader/mod.rs:
##########
@@ -429,46 +448,6 @@ where
}
impl<R: Read> Reader<R> {
- /// Create a new CsvReader from any value that implements the `Read` trait.
- ///
- /// If reading a `File` or an input that supports `std::io::Read` and
`std::io::Seek`;
- /// you can customise the Reader, such as to enable schema inference, use
- /// `ReaderBuilder`.
- #[allow(clippy::too_many_arguments)]
- pub fn new(
- reader: R,
- schema: SchemaRef,
- has_header: bool,
- delimiter: Option<u8>,
- batch_size: usize,
- bounds: Bounds,
- projection: Option<Vec<usize>>,
- datetime_format: Option<String>,
Review Comment:
I opted to just remove this method, given I was making a breaking change in
removing datetime_format anyway, and the only reason it had been kept
historically was `ReaderBuilder` required `Seek`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
