chitralverma commented on code in PR #4077:
URL: https://github.com/apache/arrow-rs/pull/4077#discussion_r1181068286
##########
object_store/src/lib.rs:
##########
@@ -717,6 +727,131 @@ impl From<Error> for std::io::Error {
}
}
+/// Creates object store from provided url and options
+///
+/// The scheme of the provided url is used to instantiate the store. If the url
+/// scheme is cannot be mapped to a store, [`NotImplemented`] is raised. For
invalid
+/// input, e.g. url with no scheme the default behaviour is to return
+/// [`local::LocalFileSystem`].
+///
+/// # Examples
+///
+/// ```
+///
+/// ```
+pub fn parse_url(
+ url: impl AsRef<str>,
+ store_options: Option<impl Into<StoreOptions>>,
+ _from_env: bool,
Review Comment:
yes, I thought about that as well. let me do something about this and then
we can merge our ideas on this.
goals -
- allow URL based obejct_store instantiation
- store options are either explicitly passed or picked from env or both
(preference given to explicit over env)
- optionally allow internal `ClientOptions` to be passed
- should work for all object stores like local, HTTP, AWS, GCS, Azure, mem
- user facing API should be simple and natural
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
