westonpace commented on code in PR #35462:
URL: https://github.com/apache/arrow/pull/35462#discussion_r1187864941


##########
cpp/src/arrow/io/memory.cc:
##########
@@ -110,6 +110,21 @@ Status BufferOutputStream::Write(const void* data, int64_t 
nbytes) {
   return Status::OK();
 }
 
+Status BufferOutputStream::Seek(int64_t position) {

Review Comment:
   On the read side we have:
   
   InputStream - non-seekable input
   ReadableFile - seekable input
   
   So I think we should use `WriteableFile` and not `OutputStream`.  Also note 
that some filesystems do not support seekable output (e.g. S3).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to