[GitHub] [arrow] icexelloss commented on a diff in pull request #35513: GH-35506: [C++] Support First and Last aggregators in Substrait

[via GitHub]

icexelloss commented on code in PR #35513:
URL: https://github.com/apache/arrow/pull/35513#discussion_r1189921713


##########
cpp/src/arrow/engine/substrait/function_test.cc:
##########
@@ -601,6 +603,7 @@ std::shared_ptr<Table> GetOutputTableForAggregateCase(
 std::shared_ptr<acero::ExecPlan> PlanFromAggregateCase(
     const AggregateTestCase& test_case, std::shared_ptr<Table>* output_table,
     bool with_keys) {
+  static ExecContext ctx_for_ordered;

Review Comment:
   I am not sure I follow how this works. Why is this static? Does this just 
default to serial execution?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org