tustvold commented on code in PR #4235:
URL: https://github.com/apache/arrow-rs/pull/4235#discussion_r1197006323
##########
object_store/src/aws/mod.rs:
##########
@@ -1002,76 +1017,74 @@ impl AmazonS3Builder {
let region = region.context(MissingRegionSnafu)?;
let checksum = self.checksum_algorithm.map(|x| x.get()).transpose()?;
- let credentials = match (self.access_key_id, self.secret_access_key,
self.token) {
- (Some(key_id), Some(secret_key), token) => {
- info!("Using Static credential provider");
- let credential = AwsCredential {
- key_id,
- secret_key,
- token,
- };
- Arc::new(StaticCredentialProvider::new(credential)) as _
- }
- (None, Some(_), _) => return Err(Error::MissingAccessKeyId.into()),
- (Some(_), None, _) => return
Err(Error::MissingSecretAccessKey.into()),
- // TODO: Replace with `AmazonS3Builder::credentials_from_env`
- _ => match (
- std::env::var("AWS_WEB_IDENTITY_TOKEN_FILE"),
- std::env::var("AWS_ROLE_ARN"),
- ) {
- (Ok(token_path), Ok(role_arn)) => {
- info!("Using WebIdentity credential provider");
-
- let session_name = std::env::var("AWS_ROLE_SESSION_NAME")
- .unwrap_or_else(|_| "WebIdentitySession".to_string());
-
- let endpoint =
format!("https://sts.{region}.amazonaws.com";);
-
- // Disallow non-HTTPs requests
- let client = self
- .client_options
- .clone()
- .with_allow_http(false)
- .client()?;
-
- let token = WebIdentityProvider {
- token_path,
- session_name,
- role_arn,
- endpoint,
- };
-
- Arc::new(TokenCredentialProvider::new(
+ let credentials = if let Some(credentials) = self.credentials {
+ credentials
Review Comment:
I'm not sure about this as some systems may source config from the
environment, which may then contain redundant credentials. I've filed
https://github.com/apache/arrow-rs/issues/4240 to track this, and will come
back to this after I've had some time to think on it, and others have had time
to weigh in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
