wjones127 commented on code in PR #4060:
URL: https://github.com/apache/arrow-rs/pull/4060#discussion_r1201520153
##########
object_store/src/aws/client.rs:
##########
@@ -243,6 +304,83 @@ impl S3Client {
Ok(())
}
+ /// Make an S3 Delete Objects request
<https://docs.aws.amazon.com/AmazonS3/latest/API/API_DeleteObjects.html>
+ ///
+ /// Produces a vector of results, one for each path in the input vector. If
+ /// the delete was successful, the path is returned in the `Ok` variant. If
+ /// there was an error for a certain path, the error will be returned in
the
+ /// vector. If there was an issue with making the overall request, an error
+ /// will be returned at the top level.
+ pub async fn bulk_delete_request(
+ &self,
+ paths: Vec<Path>,
+ ) -> Result<Vec<Result<Path>>> {
+ if paths.is_empty() {
+ return Ok(Vec::new());
+ }
+
+ let credential = self.get_credential().await?;
+ let url = format!("{}?delete", self.config.bucket_endpoint);
+
+ let inner_body = paths
+ .iter()
+ .map(|path| format!("<Object><Key>{}</Key></Object>", path))
Review Comment:
I've added a test with characters special to XML
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
