wjones127 commented on code in PR #4060:
URL: https://github.com/apache/arrow-rs/pull/4060#discussion_r1202491273


##########
object_store/src/lib.rs:
##########
@@ -1472,10 +1579,11 @@ mod tests {
 
     async fn delete_fixtures(storage: &DynObjectStore) {
         let paths = flatten_list_stream(storage, None).await.unwrap();
-
-        for f in &paths {
-            storage.delete(f).await.unwrap();
-        }
+        storage
+            .delete_stream(futures::stream::iter(paths).boxed())

Review Comment:
   It makes the API a little funky but that might be fine. In most of my 
downstream use cases, I'm probably passing in a `Vec` or iterator, so I'm 
already going to wrap in `future::stream::iter`. Having to add a `.map(Ok)` 
seems fine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to