berkaysynnada opened a new pull request, #6419:
URL: https://github.com/apache/arrow-datafusion/pull/6419
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #6125.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
With 0.34 release of sql-parser, statements can differentiate the named
windows. We can now support such queries:
```
SELECT SUM(amount) OVER running_window, AVG(amount) OVER running_window
FROM sales_us
WINDOW running_window AS (ORDER BY ts)
ORDER BY ts
LIMIT 5;
```
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
After the query parse, WindowType of the function can be in the form of
WindowSpec or NamedWindow. In `select_to_plan()` function, if there exist some
NamedWindow's, there are reshaped as WindowSpec's by using the definition of
the windows. If there are any undefined windows, an error is generated.
sqlparser dependency is also updated to 0.34 with this PR.
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Yes, slt tests are added for both working and erroneous conditions.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
