mustafasrepo commented on code in PR #6419:
URL: https://github.com/apache/arrow-datafusion/pull/6419#discussion_r1201689289
##########
datafusion/sql/src/expr/mod.rs:
##########
@@ -353,11 +353,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
let order_by = if let Some(order_by) = order_by {
// TODO: Once sqlparser supports multiple order by clause, handle
it
// see issue:
https://github.com/sqlparser-rs/sqlparser-rs/issues/875
- Some(vec![self.order_by_to_sort_expr(
- *order_by,
- input_schema,
- planner_context,
- )?])
+ Some(self.order_by_to_sort_expr(&order_by, input_schema,
planner_context)?)
Review Comment:
I think you should remove this TODO!.
I think it would be great to add an example to `groupby.slt` file, where an
aggregate function with lexicographical ordering requirement is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
