tustvold commented on code in PR #4280:
URL: https://github.com/apache/arrow-rs/pull/4280#discussion_r1205910997
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -152,43 +151,69 @@ impl<W: Write> ArrowWriter<W> {
self.writer.flushed_row_groups()
}
- /// Enqueues the provided `RecordBatch` to be written
+ /// Returns the length in bytes of the current in progress row group
+ pub fn in_progress_size(&self) -> usize {
Review Comment:
> to be more consistent with
RecordBatch (and Array) I think is the outlier in this regard:
*
https://docs.rs/arrow-schema/latest/arrow_schema/struct.Fields.html#method.size
* https://docs.rs/arrow-row/latest/arrow_row/?search=size
*
https://docs.rs/arrow/latest/arrow/datatypes/struct.UnionFields.html#method.size
I would rather keep the current name, especially as it technically isn't
really the memory size but specifically the row group size
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
