rdettai edited a comment on pull request #8910: URL: https://github.com/apache/arrow/pull/8910#issuecomment-744391019
Notes about the code: - we should create a helper that projects a schema on `Option<Vec<usize>>` to avoid having the same code duplicated all over the place, but I think this should be done in a separate PR - I removed the `schema_name` field as it isn't used anywhere (yagni) - I created an `EmptyTable`, which is convenient for tests but might also be useful for all kinds of plan manipulation where the actual data is not important. - I think the most debatable change is about the `SchemaProvider` trait in the sql planner. It was actually not a **schema** provider as it could already provide other info about UDFs / UDAFs. So I completely renamed it to `ContextProvider`, and instead of giving access to only the schema part of the table, if gives access to the entire `TableProvider`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
