westonpace commented on a change in pull request #7179:
URL: https://github.com/apache/arrow/pull/7179#discussion_r543015642
##########
File path: cpp/src/arrow/util/thread_pool.h
##########
@@ -218,7 +220,8 @@ class ARROW_EXPORT ThreadPool : public Executor {
ThreadPool();
- Status SpawnReal(TaskHints hints, std::function<void()> task) override;
+ Status SpawnReal(TaskHints hints, std::function<void()> task,
+ StopToken* = NULLPTR) override;
Review comment:
Maybe I answered my own question. The executor might get some benefit
from freeing the resources sooner rather than later (e.g. to keep queues down
and more efficient) and the executor can choose to completely ignore the stop
token without any consequence so it isn't like it is putting much burden on the
implementor of the executor interface.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
