westonpace commented on a change in pull request #7179:
URL: https://github.com/apache/arrow/pull/7179#discussion_r543589561
##########
File path: cpp/src/arrow/util/thread_pool.h
##########
@@ -218,7 +220,8 @@ class ARROW_EXPORT ThreadPool : public Executor {
ThreadPool();
- Status SpawnReal(TaskHints hints, std::function<void()> task) override;
+ Status SpawnReal(TaskHints hints, std::function<void()> task,
+ StopToken* = NULLPTR) override;
Review comment:
If the producer is creating the stop token wouldn't the correct
interface be
Result<StopToken*> SpawnReal(TaskHints hints, std::function<void()> task);
The executor is responsible for creating and returning a stop token. For
example, in the existing model, how does the executor inform the caller that it
is, in fact, cancellable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
