[GitHub] [arrow] icexelloss commented on a diff in pull request #35902: GH-35837: [C++] Acero will hang if StopProducing is called while backpressure is applied on the source node

[via GitHub]

icexelloss commented on code in PR #35902:
URL: https://github.com/apache/arrow/pull/35902#discussion_r1228456877


##########
cpp/src/arrow/acero/source_node.cc:
##########
@@ -263,6 +263,22 @@ struct SourceNode : ExecNode, public TracedNode {
     to_finish.MarkFinished();
   }
 
+  Status StopProducing() override {
+    // GH-35837: ensure node is not paused
+    Future<> to_finish;
+    {
+      std::lock_guard<std::mutex> lg(mutex_);
+      if (!backpressure_future_.is_finished()) {
+        to_finish = backpressure_future_;

Review Comment:
   @rtpsw Is this addressed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org