icexelloss commented on code in PR #35902: URL: https://github.com/apache/arrow/pull/35902#discussion_r1228459330
########## cpp/src/arrow/acero/source_node_test.cc: ########## @@ -0,0 +1,109 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include <gtest/gtest.h> + +#include "arrow/acero/exec_plan.h" +#include "arrow/acero/map_node.h" +#include "arrow/acero/options.h" +#include "arrow/acero/test_nodes.h" + +namespace arrow { +namespace acero { + +struct PauseThenStopNodeOptions : public ExecNodeOptions { + explicit PauseThenStopNodeOptions(int num_pass) : num_pass(num_pass) {} + + int num_pass; +}; + +struct PauseThenStopNode : public MapNode { + static constexpr const char* kKindName = "PauseThenStopNode"; + static constexpr const char* kFactoryName = "pause_then_stop"; + + static void Register() { + auto exec_reg = default_exec_factory_registry(); + if (!exec_reg->GetFactory(kFactoryName).ok()) { + ASSERT_OK(exec_reg->AddFactory(kFactoryName, PauseThenStopNode::Make)); + } + } + + PauseThenStopNode(ExecPlan* plan, std::vector<ExecNode*> inputs, + std::shared_ptr<Schema> output_schema, + const PauseThenStopNodeOptions& options) + : MapNode(plan, inputs, output_schema), num_pass(options.num_pass) {} + + static Result<ExecNode*> Make(ExecPlan* plan, std::vector<ExecNode*> inputs, + const ExecNodeOptions& options) { + RETURN_NOT_OK(ValidateExecNodeInputs(plan, inputs, 1, kKindName)); + auto bp_options = static_cast<const PauseThenStopNodeOptions&>(options); + if (bp_options.num_pass < 2) { + return Status::Invalid("num_pass must be at least 2"); + } + return plan->EmplaceNode<PauseThenStopNode>(plan, inputs, inputs[0]->output_schema(), + bp_options); + } + + const char* kind_name() const override { return kKindName; } + Result<ExecBatch> ProcessBatch(ExecBatch batch) override { Review Comment: @rtpsw Does this mean that the current test relies on one more batch to be delivered after PauseProducing is called, other wise this test will deadlock and never finishes? (i.e., we never call StopProducing) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
