icexelloss commented on code in PR #35874:
URL: https://github.com/apache/arrow/pull/35874#discussion_r1229987565
##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -821,8 +817,11 @@ class InputState {
++batches_processed_;
latest_ref_row_ = 0;
have_active_batch &= !queue_.TryPop();
- if (have_active_batch)
+ if (have_active_batch) {
DCHECK_GT(queue_.UnsyncFront()->num_rows(), 0); // empty batches
disallowed
+ key_hasher_->Invalidate(); // batch changed - invalidate key
hasher's cache
Review Comment:
Seems unrelated change - can you make a separate PR for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
