rtpsw commented on code in PR #35874:
URL: https://github.com/apache/arrow/pull/35874#discussion_r1231004010
##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -668,18 +663,19 @@ class InputState {
static Result<std::unique_ptr<InputState>> Make(
size_t index, TolType tolerance, bool must_hash, bool may_rehash,
- KeyHasher* key_hasher, ExecNode* node, AsofJoinNode* output,
+ KeyHasher* key_hasher, ExecNode* asof_input, AsofJoinNode* asof_node,
Review Comment:
The location you are pointing to has a different perspective of the input
and output, and should not be changed. Also note that the class there could
easily be pulled out for reuse, and should not be tied to specific internals of
as-of-join node.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
