rtpsw commented on code in PR #35874:
URL: https://github.com/apache/arrow/pull/35874#discussion_r1232188840
##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -668,18 +663,19 @@ class InputState {
static Result<std::unique_ptr<InputState>> Make(
size_t index, TolType tolerance, bool must_hash, bool may_rehash,
- KeyHasher* key_hasher, ExecNode* node, AsofJoinNode* output,
+ KeyHasher* key_hasher, ExecNode* asof_input, AsofJoinNode* asof_node,
Review Comment:
We are looking at two nodes: a node pushing to an as-of-join node. The code
here has the perspective of the latter node, so the former node is seen as an
input, which is why the code has `asof_input`. The `BackpressureController` has
the perspective of the former node, which it controls, so the latter node is
seen as an output. `BackpressureController` is designed to be reusable outside
the context of `AsofJoinNode` (even though currently it is not exposed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
