paleolimbot commented on code in PR #205: URL: https://github.com/apache/arrow-nanoarrow/pull/205#discussion_r1235475967
########## extensions/nanoarrow_device/src/nanoarrow/nanoarrow_device_cuda.c: ########## @@ -0,0 +1,376 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include <cuda_runtime_api.h> + +#include "nanoarrow_device.h" + +static void ArrowDeviceCudaAllocatorFree(struct ArrowBufferAllocator* allocator, + uint8_t* ptr, int64_t old_size) { + if (ptr != NULL) { + cudaFree(ptr); + } +} + +static uint8_t* ArrowDeviceCudaAllocatorReallocate(struct ArrowBufferAllocator* allocator, + uint8_t* ptr, int64_t old_size, + int64_t new_size) { + ArrowDeviceCudaAllocatorFree(allocator, ptr, old_size); + return NULL; Review Comment: I should probably just set `allocator->reallocate = NULL` instead of defining this...this would get called if somebody tried `ArrowBufferAppend()` on one of these, but there really isn't an opportunity to do so except in internal code within the extension and in any case `ArrowBufferAppend()` would crash when it tried to do copy the memory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
