arthurpassos commented on code in PR #35825:
URL: https://github.com/apache/arrow/pull/35825#discussion_r1238529020
##########
cpp/src/parquet/arrow/arrow_reader_writer_test.cc:
##########
@@ -610,9 +613,20 @@ class ParquetIOTestBase : public ::testing::Test {
}
void ReaderFromSink(std::unique_ptr<FileReader>* out) {
+ return ReaderFromSink(out, default_arrow_reader_properties());
+ }
+
+ void ReaderFromSink(std::unique_ptr<FileReader>* out,
+ const ArrowReaderProperties& arrow_reader_properties) {
Review Comment:
I guess I was just trying to avoid default parameters, but I can do a
default argument if that's what you prefer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
