pitrou commented on code in PR #36244:
URL: https://github.com/apache/arrow/pull/36244#discussion_r1238613590


##########
dev/merge_arrow_pr.py:
##########
@@ -421,8 +421,19 @@ def merge_pr(self, number, commit_title, commit_message):
         if response.status_code != 200 and 'merged' not in result:
             result['merged'] = False
             result['message'] += f': {url}'
+        else:
+            self.clear_pr_state_labels(number)

Review Comment:
   Is there a logic error here? Should we clear the PR labels only if "merged" 
appears in the result?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to