raulcd commented on code in PR #36244:
URL: https://github.com/apache/arrow/pull/36244#discussion_r1238666597
##########
dev/merge_arrow_pr.py:
##########
@@ -418,11 +418,23 @@ def merge_pr(self, number, commit_title, commit_message):
}
response = requests.put(url, headers=self.headers, json=payload)
result = response.json()
- if response.status_code != 200 and 'merged' not in result:
+ if response.status_code == 200 and 'merged' in result:
Review Comment:
btw based on the API if the result is 200 the merge was successful and
`merged` will always be true.
https://docs.github.com/en/rest/pulls/pulls?apiVersion=2022-11-28#merge-a-pull-request
I am sure we can mark this as `False` if those are not successful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
