WillAyd commented on code in PR #765:
URL: https://github.com/apache/arrow-adbc/pull/765#discussion_r1238892112
##########
adbc.h:
##########
@@ -907,6 +1008,34 @@ AdbcStatusCode AdbcDatabaseNew(struct AdbcDatabase*
database, struct AdbcError*
AdbcStatusCode AdbcDatabaseGetOption(struct AdbcDatabase* database, const
char* key,
const char** value, struct AdbcError*
error);
+/// \brief Get a bytestring option of the database.
+///
+/// This must always be thread-safe (other operations are not).
Review Comment:
Any reason to not follow the pattern of functions like vsnprintf? i.e. print
what you can but ultimately left to the caller to determine if the size was
sufficient
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
