WillAyd commented on code in PR #765:
URL: https://github.com/apache/arrow-adbc/pull/765#discussion_r1238921965


##########
adbc.h:
##########
@@ -907,6 +1008,34 @@ AdbcStatusCode AdbcDatabaseNew(struct AdbcDatabase* 
database, struct AdbcError*
 AdbcStatusCode AdbcDatabaseGetOption(struct AdbcDatabase* database, const 
char* key,
                                      const char** value, struct AdbcError* 
error);
 
+/// \brief Get a bytestring option of the database.
+///
+/// This must always be thread-safe (other operations are not).

Review Comment:
   Fair. I'm also not sure why functions like vsnprintf choose to do that in 
the first place; maybe some POSIX convention



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to