viirya commented on code in PR #6654:
URL: https://github.com/apache/arrow-datafusion/pull/6654#discussion_r1244325250
##########
datafusion/physical-expr/src/datetime_expressions.rs:
##########
@@ -262,6 +266,55 @@ fn date_trunc_single(granularity: &str, value: i64) ->
Result<i64> {
Ok(value.unwrap().timestamp_nanos())
}
+fn _date_trunc(
+ tu: TimeUnit,
+ value: &Option<i64>,
+ granularity: &str,
+ f: impl Fn(Option<i64>) -> Result<Option<i64>>,
+) -> Result<Option<i64>, DataFusionError> {
+ let scale = match tu {
+ TimeUnit::Second => 1_000_000_000,
+ TimeUnit::Millisecond => 1_000_000,
+ TimeUnit::Microsecond => 1_000,
+ TimeUnit::Nanosecond => 1,
+ };
+
+ let Some(value) = value else {
+ return Ok(None);
+ };
+
+ // convert to nanoseconds
+ let Some(nano) = (f)(Some(value * scale))? else {
+ return Ok(None);
+ };
+
+ let result = match tu {
+ TimeUnit::Second => match granularity {
+ "minute" => Some(nano / 1_000_000_000 / 60 * 60),
+ _ => Some(nano / 1_000_000_000),
+ },
+ TimeUnit::Millisecond => match granularity {
+ "minute" => Some(nano / 1_000_000 / 1_000 / 60 * 1_000 * 60),
+ "second" => Some(nano / 1_000_000 / 1_000 * 1_000),
+ _ => Some(nano / 1_000_000),
+ },
+ TimeUnit::Microsecond => match granularity {
+ "minute" => Some(nano / 1_000 / 1_000_000 / 60 * 60 * 1_000_000),
+ "second" => Some(nano / 1_000 / 1_000_000 * 1_000_000),
+ "millisecond" => Some(nano / 1_000 / 1_000 * 1_000),
+ _ => Some(nano / 1_000),
+ },
+ _ => match granularity {
+ "minute" => Some(nano / 1_000_000_000 / 60 * 1_000_000_000 * 60),
+ "second" => Some(nano / 1_000_000_000 * 1_000_000_000),
+ "millisecond" => Some(nano / 1_000_000 * 1_000_000),
+ "microsecond" => Some(nano / 1_000 * 1_000),
+ _ => Some(nano),
+ },
Review Comment:
Looks correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
