mrkn commented on a change in pull request #8919:
URL: https://github.com/apache/arrow/pull/8919#discussion_r546043171
##########
File path: ruby/red-arrow/lib/arrow/array-builder.rb
##########
@@ -115,6 +115,17 @@ def detect_builder_info(value, builder_info)
builder: Date32ArrayBuilder.new,
detected: true,
}
+ when BigDecimal
+ if value.precs[0] > Arrow::Decimal128DataType::MAX_PRECISION
Review comment:
We should add tests of converting from/to `BigDecimal("1e30")` and
`BigDecimal("1e70")`. `precs` of them are both `[9, 18]`, but they should be
converted to `Decimal128` and `Decimal256`, respectively.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
