Dandandan commented on code in PR #6954:
URL: https://github.com/apache/arrow-datafusion/pull/6954#discussion_r1262819183
##########
datafusion/physical-expr/src/aggregate/groups_accumulator/accumulate.rs:
##########
@@ -139,10 +139,14 @@ impl NullState {
// no nulls, no filter,
(false, None) => {
let iter = group_indices.iter().zip(data.iter());
+
for (&group_index, &new_value) in iter {
- seen_values.set_bit(group_index, true);
value_fn(group_index, new_value);
}
+ // update seen values in separate loop
+ for &group_index in group_indices.iter() {
+ seen_values.set_bit(group_index, true);
Review Comment:
Can't we assume `seen_values` is true for every group_index for "no nulls,
no filter" until we observed a first null-value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
