alamb opened a new pull request, #6954: URL: https://github.com/apache/arrow-datafusion/pull/6954
Draft as I am running performance tests and will clean up the code a bit if possible. # Which issue does this PR close? Part of https://github.com/apache/arrow-datafusion/issues/6889 This is a follow on to https://github.com/apache/arrow-datafusion/pull/6904 where some last minute changes (to track null state correctly) decreased performance slightly -- I am trying to get some back # Rationale for this change I am trying to help the compiler to vectorize the inner loops of the accumulators. Let's do this by doing the minimal work as possible # What changes are included in this PR? Update null state with a separate loop <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> # Are these changes tested? covered by existing tests <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
