wgtmac commented on code in PR #34616:
URL: https://github.com/apache/arrow/pull/34616#discussion_r1270266377
##########
cpp/src/arrow/dataset/file_parquet.h:
##########
@@ -236,11 +252,25 @@ class ARROW_DS_EXPORT ParquetFileWriteOptions : public
FileWriteOptions {
/// \brief Parquet Arrow writer properties.
std::shared_ptr<parquet::ArrowWriterProperties> arrow_writer_properties;
+ /// \brief A getter function to retrieve the parquet encryption configuration
Review Comment:
ditto
##########
cpp/src/arrow/dataset/file_parquet.h:
##########
@@ -226,6 +229,19 @@ class ARROW_DS_EXPORT ParquetFragmentScanOptions : public
FragmentScanOptions {
/// ScanOptions. Additionally, dictionary columns come from
/// ParquetFileFormat::ReaderOptions::dict_columns.
std::shared_ptr<parquet::ArrowReaderProperties> arrow_reader_properties;
+ /// \brief A getter function to retrieve the parquet decryption configuration
+ std::shared_ptr<ParquetDecryptionConfig> GetParquetDecryptionConfig() const {
+ return parquet_decryption_config_;
+ }
+ /// \brief A setter for ParquetDecryptionConfig
+ void SetParquetDecryptionConfig(
+ std::shared_ptr<ParquetDecryptionConfig> parquet_decryption_config) {
+ parquet_decryption_config_ = std::move(parquet_decryption_config);
+ }
Review Comment:
Is it better to be consistent and not use setter and getter here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
