lidavidm commented on code in PR #948:
URL: https://github.com/apache/arrow-adbc/pull/948#discussion_r1278150826
##########
c/validation/adbc_validation.cc:
##########
@@ -1095,8 +1100,12 @@ void StatementTest::TestSqlIngestBinary() {
NANOARROW_TYPE_BINARY, {std::nullopt, "", "\x00\x01\x02\x04",
"\xFE\xFF"}));
}
+void StatementTest::TestSqlIngestDate32() {
+
ASSERT_NO_FATAL_FAILURE(TestSqlIngestNumericType<int32_t>(NANOARROW_TYPE_DATE32));
Review Comment:
More verbose, but then for drivers where there's overlap (e.g. Postgres in
Java, Postgres in C++) we can also use them to assert that the behavior
matches. The problem is checking in binaries; I was thinking we could borrow
the arrow-testing submodule to do that to avoid cluttering the main repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
