lidavidm commented on code in PR #948:
URL: https://github.com/apache/arrow-adbc/pull/948#discussion_r1279821753
##########
c/validation/adbc_validation.cc:
##########
@@ -1037,6 +1037,10 @@ void StatementTest::TestSqlIngestNumericType(ArrowType
type) {
// values. Likely a bug on our side, but for now, avoid them.
values.push_back(static_cast<CType>(-1.5));
values.push_back(static_cast<CType>(1.5));
+ } else if (type == ArrowType::NANOARROW_TYPE_DATE32) {
+ // Windows does not seem to support negative date values
+ values.push_back(static_cast<CType>(0));
Review Comment:
Ugh.
I wonder if we shouldn't also consider vendoring a library for that down the
line...that would be easier if/when we also consolidate the driver codebases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
