viirya commented on code in PR #6832:
URL: https://github.com/apache/arrow-datafusion/pull/6832#discussion_r1278621222
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -2609,14 +2441,14 @@ mod tests {
Operator::Divide,
create_decimal_array(
&[
- Some(99193548387), // 0.99193548387
Review Comment:
I think that the rules for precision of decimal division are changed. I
won't say previous rules are incorrect.
And, obviously it is precision loss here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
