viirya commented on code in PR #6832: URL: https://github.com/apache/arrow-datafusion/pull/6832#discussion_r1278622152
########## datafusion/core/tests/sqllogictests/test_files/decimal.slt: ########## @@ -365,7 +365,7 @@ select c1*c5 from decimal_simple; query T select arrow_typeof(c1/cast(0.00001 as decimal(5,5))) from decimal_simple limit 1; ---- -Decimal128(21, 12) +Decimal128(19, 10) Review Comment: I won't say this is not correct, this is more like a design decision to me. But this actually changes the precision of decimal arithmetic operations in DataFusion. For some, this might be a different change and not something could be implicitly accepted. I'd suggest there are some documents on these changes with new release including this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
