sgilmore10 opened a new pull request, #37015:
URL: https://github.com/apache/arrow/pull/37015

   <!--
   Thanks for opening a pull request!
   If this is your first pull request you can find detailed information on how 
   to contribute here:
     * [New Contributor's 
Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
     * [Contributing 
Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
   
   
   If this is not a [minor 
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). 
Could you open an issue for this pull request on GitHub? 
https://github.com/apache/arrow/issues/new/choose
   
   Opening GitHub issues ahead of time contributes to the 
[Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.)
 of the Apache Arrow project.
   
   Then could you also rename the pull request title in the following format?
   
       GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   In the case of PARQUET issues on JIRA the title also supports:
   
       PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   -->
   
   ### Rationale for this change
   
   Similar to the utility added in #36853, it would be helpful to have one that 
creates Array proxies from existing `arrow::Array` objects. This will help us 
implement methods that extract arrays from compound objects, such as 
`arrow::RecordBatch`, `arrow::StructArray`, etc.
   
   ### What changes are included in this PR?
   
   Added one new function: 
   
   ```cpp
   arrow::Result<arrow::matlab::array::proxy::Array> wrap(const 
std::shared_ptr<arrow::Array>& array);
   ```
   
   This function creates proxy objects from existing arrow arrays.
   
   ### Are these changes tested?
   
   We are not using this utility yet, but we will use it in `RecordBatch` proxy 
object. Once we do, we will be able to test it. If you prefer I wait to submit 
this utility, please let me know.
   
   ### Are there any user-facing changes?
   
   No.
   
   ### Future Directions
   
   1. In a followup PR, we plan on changing the implementation of the 
`arrow.tabular.RecordBatch/column(idx)` to extract array proxies from the C++ 
`arrow::RecordBatch`. When we do that, we will can use this utility and test it.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to