sgilmore10 commented on code in PR #37015:
URL: https://github.com/apache/arrow/pull/37015#discussion_r1284706913
##########
matlab/src/cpp/arrow/matlab/tabular/proxy/record_batch.cc:
##########
@@ -18,17 +18,42 @@
#include "libmexclass/proxy/ProxyManager.h"
#include "arrow/matlab/array/proxy/array.h"
+#include "arrow/matlab/array/proxy/wrap.h"
+
#include "arrow/matlab/error/error.h"
#include "arrow/matlab/tabular/proxy/record_batch.h"
#include "arrow/type.h"
#include "arrow/util/utf8.h"
+#include "libmexclass/proxy/ProxyManager.h"
+#include "libmexclass/error/Error.h"
+
+#include <sstream>
+
namespace arrow::matlab::tabular::proxy {
+ namespace {
+ libmexclass::error::Error make_empty_record_batch_error() {
Review Comment:
That's a good point. I'll change the function names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
