alamb commented on PR #7180:
URL:
https://github.com/apache/arrow-datafusion/pull/7180#issuecomment-1666117428
> TLDR: unstable sort and changed batch sizes result in different order of
items with the same value in the sort column between main and this PR.
very nice 🕵️ work
> Perhaps it's ok to change the test output to match the one being obtained
now?
```sql
SELECT
MAX(c12) OVER window1,
MIN(c12) OVER window2 as max1
FROM aggregate_test_100
WINDOW window1 AS (ORDER BY C12),
window2 AS (PARTITION BY C11),
window3 AS (ORDER BY C1)
ORDER BY C3
LIMIT 5
```
If you are saying there are more than 5 values with the same value of c5
then I think technically the query produces non specified answers and thus I
think we should change the test to be deterministic -- perhaps we can increase
the `LIMIT` to include all the first values of `c3`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
