alamb commented on code in PR #7180:
URL: https://github.com/apache/arrow-datafusion/pull/7180#discussion_r1283098372
##########
datafusion/core/src/physical_plan/sorts/sort.rs:
##########
@@ -133,11 +131,28 @@ impl ExternalSorter {
/// Appends an unsorted [`RecordBatch`] to `in_mem_batches`
///
/// Updates memory usage metrics, and possibly triggers spilling to disk
- async fn insert_batch(&mut self, input: RecordBatch) -> Result<()> {
+ async fn insert_batch(&mut self, mut input: RecordBatch) -> Result<()> {
if input.num_rows() == 0 {
return Ok(());
}
+ let mut batch_sorted = false;
+ if self.fetch.map_or(false, |f| f < input.num_rows()) {
+ // Eagerly sort the batch to potentially reduce the number of rows
+ // after applying the fetch parameter; first perform a memory
reservation
+ // for the sorting procedure.
+ let mut reservation =
+ MemoryConsumer::new(format!("insert_batch{}",
self.partition_id))
+ .register(&self.runtime.memory_pool);
+
+ // TODO: This should probably be try_grow (#5885)
+ reservation.resize(input.get_array_memory_size());
+ // Maybe we should perform sorting in a parallel task to unblock
the caller
Review Comment:
if the parallelization is working correctly all the other cores should be
busy doing something useful here -- and thus sorting in another task may not be
warranted but I am not sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
