benibus commented on PR #37032: URL: https://github.com/apache/arrow/pull/37032#issuecomment-1666999266
I was able to use the new benchmarks at four different points in time. Got some interesting results... (these are all approximate best-case) #### Immediately before PR-35197 This was right after I added initial support for tables/chunked arrays. Fortunately, those implementations probably didn't see any use before they were replaced. ``` FieldPathGetFromWideArray 4231818 ns 4231770 ns 164 items_per_second=2.36308M/s FieldPathGetFromWideArrayData 1103845 ns 1103830 ns 626 items_per_second=9.05937M/s FieldPathGetFromWideBatch 4251668 ns 4251632 ns 165 items_per_second=2.35204M/s FieldPathGetFromWideTable 1.3847e+10 ns 1.3847e+10 ns 1 items_per_second=722.19/s FieldPathGetFromWideChunkedArray/2 2.2871e+11 ns 2.2870e+11 ns 1 items_per_second=43.7258/s FieldPathGetFromWideChunkedArray/8 8.8894e+10 ns 8.8892e+10 ns 1 items_per_second=112.496/s FieldPathGetFromWideChunkedArray/32 4.9146e+10 ns 4.9145e+10 ns 1 items_per_second=203.48/s FieldPathGetFromWideChunkedArray/100 3.8052e+10 ns 3.8051e+10 ns 1 items_per_second=262.802/s ``` #### Immediately after PR-35197 Major regressions for array data and record batches. ``` FieldPathGetFromWideArray 4006585 ns 4006560 ns 174 items_per_second=2.49591M/s FieldPathGetFromWideArrayData 3190691414 ns 3190582067 ns 1 items_per_second=3.13422k/s FieldPathGetFromWideBatch 4362726666 ns 4362483392 ns 1 items_per_second=2.29227k/s FieldPathGetFromWideTable 3250066 ns 3249963 ns 216 items_per_second=3.07696M/s FieldPathGetFromWideChunkedArray/2 298990880 ns 298973212 ns 2 items_per_second=33.4478k/s FieldPathGetFromWideChunkedArray/8 46501931 ns 46500714 ns 12 items_per_second=215.05k/s FieldPathGetFromWideChunkedArray/32 20925483 ns 20924825 ns 31 items_per_second=477.901k/s FieldPathGetFromWideChunkedArray/100 12508686 ns 12508268 ns 54 items_per_second=799.471k/s ``` #### Immediately before this PR At some point, performance went way up for everything besides array data and batches. Not sure why. ``` FieldPathGetFromWideArray 628388 ns 628356 ns 1108 items_per_second=15.9145M/s FieldPathGetFromWideArrayData 1659049537 ns 1659040097 ns 1 items_per_second=6.02758k/s FieldPathGetFromWideBatch 2465863699 ns 2465831041 ns 1 items_per_second=4.05543k/s FieldPathGetFromWideTable 373124 ns 373118 ns 1876 items_per_second=26.8012M/s FieldPathGetFromWideChunkedArray/2 25216611 ns 25215747 ns 22 items_per_second=396.578k/s FieldPathGetFromWideChunkedArray/8 6216094 ns 6215197 ns 96 items_per_second=1.60896M/s FieldPathGetFromWideChunkedArray/32 2292445 ns 2292410 ns 299 items_per_second=4.36222M/s FieldPathGetFromWideChunkedArray/100 1109909 ns 1109902 ns 628 items_per_second=9.0098M/s ``` #### Immediately after this PR ``` FieldPathGetFromWideArray 619903 ns 619883 ns 1123 items_per_second=16.1321M/s FieldPathGetFromWideArrayData 431889 ns 431878 ns 1622 items_per_second=23.1547M/s FieldPathGetFromWideBatch 575262 ns 575236 ns 1216 items_per_second=17.3842M/s FieldPathGetFromWideTable 371890 ns 371888 ns 1882 items_per_second=26.8898M/s FieldPathGetFromWideChunkedArray/2 23430915 ns 23429532 ns 24 items_per_second=426.812k/s FieldPathGetFromWideChunkedArray/8 5858929 ns 5858709 ns 100 items_per_second=1.70686M/s FieldPathGetFromWideChunkedArray/32 2176156 ns 2176124 ns 317 items_per_second=4.59533M/s FieldPathGetFromWideChunkedArray/100 1066176 ns 1066129 ns 647 items_per_second=9.37973M/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
