gruuya commented on PR #7180: URL: https://github.com/apache/arrow-datafusion/pull/7180#issuecomment-1667235351
> Would it be possible to compare the sorting performance of this pull request with the main branch by modifying the test sets in the description of [#6163](https://github.com/apache/arrow-datafusion/pull/6163) with different values of `K`? Certainly; I started up a slightly modified sorting benchmark with an additional [outer loop](https://github.com/apache/arrow-datafusion/blob/main/benchmarks/src/bin/parquet.rs#L202-L214) `for fetch in &[None, Some(1), Some(10), Some(100), Some(1000), Some(10000)]`. The idea is that the first and last case should not hit the eager sorting code heuristic (because of the missing fetch, and fetch being larger than batch sizes respectively), so they should be same as on main. Will report back today hopefully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
