devinjdangelo commented on code in PR #7229:
URL: https://github.com/apache/arrow-datafusion/pull/7229#discussion_r1287674162
##########
datafusion/core/src/datasource/file_format/mod.rs:
##########
@@ -235,7 +239,7 @@ pub(crate) enum AbortMode {
}
/// A wrapper struct with abort method and writer
-struct AbortableWrite<W: AsyncWrite + Unpin + Send> {
+pub(crate) struct AbortableWrite<W: AsyncWrite + Unpin + Send> {
Review Comment:
That is a good idea. The code is likely to become more complex / long with
additional helpers as we get into parallelization and dealing with parquet. I'm
working on a PR to add support for inserting parquet now, and I can consolidate
the shared write code into a new module as part of that.
##########
datafusion/core/src/datasource/file_format/csv.rs:
##########
@@ -494,56 +490,6 @@ impl CsvSink {
file_compression_type,
}
}
-
- // Create a write for Csv files
- async fn create_writer(
Review Comment:
Nice catch!
##########
datafusion/core/src/datasource/file_format/file_type.rs:
##########
@@ -62,7 +62,7 @@ pub trait GetExt {
}
/// Readable file compression type
-#[derive(Debug, Clone, PartialEq, Eq)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
Review Comment:
❤️
##########
datafusion/core/src/datasource/file_format/file_type.rs:
##########
@@ -62,7 +62,7 @@ pub trait GetExt {
}
/// Readable file compression type
-#[derive(Debug, Clone, PartialEq, Eq)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
Review Comment:
❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
