indigophox commented on code in PR #34817: URL: https://github.com/apache/arrow/pull/34817#discussion_r1289328233
########## cpp/src/arrow/flight/sql/protocol_internal.h: ########## @@ -24,3 +24,4 @@ #include "arrow/flight/sql/visibility.h" #include "arrow/flight/sql/FlightSql.pb.h" // IWYU pragma: export +#include "arrow/flight/Flight.pb.h" Review Comment: Not super familiar with how the Windows linkage works here, do you mean: * Façade(?) (presumable with an MVP set of functionality passed through from the Proto types) in libarrow_flight, i.e. in... flight/protocol_internal.h or another (new?) module? * Including the base Flight protocol_internal.h in sql/protocol_internal.h (to expose the symbols for dynamic import)? * And I assume no changes required to add a dynamic dependency of libarrow_flight on libarrow_flight_sql (which already exists?) TIA! ########## cpp/src/arrow/flight/sql/protocol_internal.h: ########## @@ -24,3 +24,4 @@ #include "arrow/flight/sql/visibility.h" #include "arrow/flight/sql/FlightSql.pb.h" // IWYU pragma: export +#include "arrow/flight/Flight.pb.h" Review Comment: Not super familiar with how the Windows linkage works here, do you mean: * Façade(?) (presumable with an MVP set of functionality passed through from the Proto types) in libarrow_flight, i.e. in... flight/protocol_internal.h or another (new?) module? * Including the base Flight protocol_internal.h in sql/protocol_internal.h (to expose the symbols for dynamic import)? * And I assume no changes required to add a dynamic dependency of libarrow_flight on libarrow_flight_sql (which already exists?) TIA! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
