indigophox commented on code in PR #34817: URL: https://github.com/apache/arrow/pull/34817#discussion_r1289345138
########## cpp/src/arrow/flight/sql/protocol_internal.h: ########## @@ -24,3 +24,4 @@ #include "arrow/flight/sql/visibility.h" #include "arrow/flight/sql/FlightSql.pb.h" // IWYU pragma: export +#include "arrow/flight/Flight.pb.h" Review Comment: So I guess (despite our discussion about keeping all the handler code in fSQL) that means having the Proto ser/de in libarrow itself? Trying to think how this is going to work given where ParseAction*Request() and PackActionResult() calls are—I guess even without handlers being there the Parse/Pack functions can live in libarrow, including the overloaded PackActionResult, although that in turn doesn't have visibility of the generic PackActionResult (if it's in libarrow, which otherwise has no concept of Action I believe) so... any thoughts on how that's actually going to end up laid out to solve the visibility & linkage issues in a sane/tidy way? ########## cpp/src/arrow/flight/sql/protocol_internal.h: ########## @@ -24,3 +24,4 @@ #include "arrow/flight/sql/visibility.h" #include "arrow/flight/sql/FlightSql.pb.h" // IWYU pragma: export +#include "arrow/flight/Flight.pb.h" Review Comment: So I guess (despite our discussion about keeping all the handler code in fSQL) that means having the Proto ser/de in libarrow itself? Trying to think how this is going to work given where ParseAction*Request() and PackActionResult() calls are—I guess even without handlers being there the Parse/Pack functions can live in libarrow, including the overloaded PackActionResult, although that in turn doesn't have visibility of the generic PackActionResult (if it's in libarrow, which otherwise has no concept of Action I believe) so... any thoughts on how that's actually going to end up laid out to solve the visibility & linkage issues in a sane/tidy way? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
