devinjdangelo commented on code in PR #7244:
URL: https://github.com/apache/arrow-datafusion/pull/7244#discussion_r1291308878
##########
datafusion/core/src/datasource/listing/table.rs:
##########
@@ -1584,11 +1590,127 @@ mod tests {
helper_test_append_new_files_to_table(
FileType::CSV,
FileCompressionType::UNCOMPRESSED,
+ None,
)
.await?;
Ok(())
}
+ #[tokio::test]
+ async fn test_insert_into_append_new_parquet_files_defaults() ->
Result<()> {
+ helper_test_append_new_files_to_table(
+ FileType::PARQUET,
+ FileCompressionType::UNCOMPRESSED,
+ None,
+ )
+ .await?;
+ Ok(())
+ }
+
+ #[tokio::test]
+ async fn test_insert_into_append_new_parquet_files_session_overrides() ->
Result<()> {
Review Comment:
We may want to add additional tests for writing parquet that fuzz these
input settings and write out some larger parquet files so that the configs
actually have some effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
