pitrou commented on code in PR #37174:
URL: https://github.com/apache/arrow/pull/37174#discussion_r1303214836
##########
go/arrow/cdata/cdata_test_framework.go:
##########
@@ -277,6 +283,12 @@ func createCArr(arr arrow.Array) *CArrowArray {
carr.length = C.int64_t(arr.Len())
carr.null_count = C.int64_t(arr.NullN())
carr.offset = C.int64_t(arr.Data().Offset())
+ carr.release = (*[0]byte)(C.release_test_arr)
+
+ if !arrow.IsUnion(arr.DataType().ID()) &&
!internal.DefaultHasValidityBitmap(arr.DataType().ID()) {
Review Comment:
I meant more something along the lines of `len(buffers) > 0`. Why do we have
to special-case this for unions and the validity bitmap? Or is this `if` clause
even useful?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
