zeroshade commented on code in PR #37174:
URL: https://github.com/apache/arrow/pull/37174#discussion_r1303226376
##########
go/arrow/cdata/cdata_test_framework.go:
##########
@@ -277,6 +283,12 @@ func createCArr(arr arrow.Array) *CArrowArray {
carr.length = C.int64_t(arr.Len())
carr.null_count = C.int64_t(arr.NullN())
carr.offset = C.int64_t(arr.Data().Offset())
+ carr.release = (*[0]byte)(C.release_test_arr)
+
+ if !arrow.IsUnion(arr.DataType().ID()) &&
!internal.DefaultHasValidityBitmap(arr.DataType().ID()) {
Review Comment:
Let me double check. I think there are still areas of the code which assume
there is at least one element in the list of buffers (even if it's nil). For
REE arrays (along with others) we initialize the buffer list with a single nil.
I'll look through the code and see if it's safe enough to just let the slice of
buffers be empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
