viirya commented on code in PR #7443:
URL: https://github.com/apache/arrow-datafusion/pull/7443#discussion_r1309108333
##########
datafusion/substrait/src/logical_plan/producer.rs:
##########
@@ -1378,6 +1383,15 @@ fn to_substrait_bound(bound: &WindowFrameBound) -> Bound
{
}
}
+fn to_substrait_bound_type(window_frame: &WindowFrame) -> Result<BoundsType> {
+ match window_frame.units {
+ WindowFrameUnits::Rows => Ok(BoundsType::Rows), // ROWS
+ WindowFrameUnits::Range => Ok(BoundsType::Range), // RANGE
+ // TODO: Support GROUPS
+ unit => not_impl_err!("Unsupported window frame unit: {unit:?}"),
Review Comment:
substrait `WindowFrameUnits` doesn't support GROUPS frame type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
